Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update build and push github action version #346

Merged
merged 1 commit into from
Feb 4, 2025
Merged

update build and push github action version #346

merged 1 commit into from
Feb 4, 2025

Conversation

agbpatro
Copy link
Collaborator

@agbpatro agbpatro commented Feb 4, 2025 •
edited
Loading

Description

#345 didn't work. Bumping versions in github actions to see the release pipeline is fixed. I see some discussion in docker/buildx#1986 and based on that, trying to see if bumping up versions fixes it

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@agbpatro agbpatro marked this pull request as ready for review February 4, 2025 01:19
@agbpatro agbpatro merged commit f6a816e into main Feb 4, 2025
5 checks passed
@agbpatro agbpatro deleted the fix_publishing_take2 branch February 4, 2025 01:43
@agbpatro agbpatro mentioned this pull request Feb 4, 2025
Merged
9 tasks
agbpatro added a commit that referenced this pull request Feb 4, 2025
@agbpatro
Revert "update build and push github action version (#346)"
b1d101c 
This reverts commit f6a816e.
agbpatro added a commit that referenced this pull request Feb 4, 2025
@agbpatro
fix publishing of docker images (#347)
8ce70f7 
* Revert "update build and push github action version (#346)"

This reverts commit f6a816e.

* Revert "install dependencies in image to get rid of build errors (#345)"

This reverts commit 31dacb7.

* Pin version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdemers6 patrickdemers6 patrickdemers6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agbpatro @patrickdemers6