add sm.requestIdentity.DeviceID to debug log for reliable ack #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickdemers6
requested changes
Feb 18, 2025
server/streaming/socket.go
Outdated
| @@ -293,10 +293,9 @@ func (sm *SocketManager) processRecord(record *telemetry.Record) { | |||
| func (sm *SocketManager) respondToVehicle(record *telemetry.Record, err error) { | |||
| var response []byte | |||
|
|
|||
| logInfo := logrus.LogInfo{"txid": record.Txid, "record_type": record.TxType} | |||
| logInfo := logrus.LogInfo{"txid": record.Txid, "record_type": record.TxType, "client_id": sm.requestIdentity.DeviceID} | |||
There was a problem hiding this comment.
client_id seems like an odd choice here. Maybe device_id?
agbpatro
force-pushed
the
update_debug_log
branch
2 times, most recently
from
25194bb to
12e3e52
Compare
agbpatro
force-pushed
the
update_debug_log
branch
from
12e3e52 to
5155aa8
Compare
patrickdemers6
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will be helpful to always have client id in debug logs
Fixes # (issue)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: