Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reliable acks only processed for one tx type #365

Merged

Conversation

patrickdemers6
Copy link
Collaborator

Description

The logic for configuring reliable acks only enables acks for the last tx type processed.

If a configuration calls for Kafka reliable acks for both errors and V, only one of the tx types will have acks processed. This happens non-deterministically.

This PR handles reliable acks for multiple tx types properly.

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@patrickdemers6 patrickdemers6 force-pushed the fix-multiple-reliable-acks branch from 45a32d8 to cc119b6 Compare February 18, 2025 23:47
@patrickdemers6 patrickdemers6 merged commit fc3e6eb into teslamotors:main Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants