fix reliable acks only processed for one tx type #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic for configuring reliable acks only enables acks for the last tx type processed.
If a configuration calls for Kafka reliable acks for both
errors
andV
, only one of the tx types will have acks processed. This happens non-deterministically.This PR handles reliable acks for multiple tx types properly.
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: