Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(integration): update kinesis docker image #368

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

emirot
Copy link
Contributor

@emirot emirot commented Feb 23, 2025

Description

Proposal: update kinesis docker image used in integration tests.

Why

The current image saidsef/aws-kinesis-local had only has 2 contributor and 21 stars, there is a risk it will go out of maintenance.

That's why I proposed to use localstack which has hundreads of contributors and over 50k stars, moreover this is under apache 2 license.

Fixes # (issue)

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@emirot
Copy link
Contributor Author

emirot commented Feb 23, 2025

@ThomasAlxDmy @patrickdemers6 @vmallet please review

@agbpatro agbpatro merged commit 646fce2 into teslamotors:main Feb 28, 2025
1 check passed
@emirot emirot deleted the test/updatekinesisimage branch February 28, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants