Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify server certificate chain that includes intermediate certificate #372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Verify server certificate chain that includes intermediate certificate #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ By configuring `fleet_telemetry_config`, individual owners and fleet operators c
- From a local computer, create `validate_server.json` with the following fields:
- `hostname`: The hostname the fleet-telemetry server.
- `port`: The port the fleet-telemetry server -- Default 443.
- `ca`: The full certificate chain used to generate the server's TLS certificate.
- `ca`: The certificate authority used to generate the server's TLS certificate.
- Run `./check_server_cert.sh validate_server.json`
9. Pair the application's virtual key to the vehicle(s). See documentation here: https://developer.tesla.com/docs/fleet-api/virtual-keys/developer-guide.
10. Configure and run the [vehicle-command proxy](https://github.com/teslamotors/vehicle-command#installation-and-configuration) with the application private key.
Expand Down Expand Up @@ -98,7 +98,7 @@ For ease of installation and operation, run Fleet Telemetry on Kubernetes or a s
]
},
"tls": {
"server_cert": string - server cert location,
"server_cert": string - server cert chain location,
"server_key": string - server key location
}
}
Expand Down
9 changes: 7 additions & 2 deletions tools/check_server_cert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,28 @@ CA=$(jq -r ".ca" "$CONFIG")
PORT=$(jq -r '.port // 443' "$CONFIG")

CA_CERT_FILE=$(mktemp)
INTERMEDIATE_CERT_FILE=$(mktemp)
SERVER_CERT_FILE=$(mktemp)
TMP_SERVER_CERT_FILE=$(mktemp)
echo "$CA" > "$CA_CERT_FILE"

echo | openssl s_client -connect "$HOSTNAME:$PORT" -servername "$HOSTNAME" -showcerts 2>/dev/null > "$TMP_SERVER_CERT_FILE"
openssl x509 -in "$TMP_SERVER_CERT_FILE" -outform PEM > "$SERVER_CERT_FILE"
awk '/-----BEGIN CERTIFICATE-----/&&++k==2,/-----END CERTIFICATE-----/' "$TMP_SERVER_CERT_FILE" > "$INTERMEDIATE_CERT_FILE"

if openssl verify -CAfile "$CA_CERT_FILE" "$SERVER_CERT_FILE"; then
if openssl verify -CAfile "$CA_CERT_FILE" "$SERVER_CERT_FILE" 2>/dev/null; then
success "The server certificate is valid."
else
if openssl verify -partial_chain -CAfile "$CA_CERT_FILE" "$SERVER_CERT_FILE"; then
if [ -s "$INTERMEDIATE_CERT_FILE" ] && openssl verify -CAfile "$CA_CERT_FILE" -untrusted "$INTERMEDIATE_CERT_FILE" "$SERVER_CERT_FILE" 2>/dev/null; then
success "The server certificate chain is valid."
elif openssl verify -partial_chain -CAfile "$CA_CERT_FILE" "$SERVER_CERT_FILE" 2>/dev/null; then
warning "The server certificate has a valid partial chain, and may work with the root chain."
else
error "The server certificate is invalid."
fi
fi

rm "$CA_CERT_FILE"
rm "$INTERMEDIATE_CERT_FILE"
rm "$SERVER_CERT_FILE"
rm "$TMP_SERVER_CERT_FILE"