Allow transmitting data in json bytes #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpkahn
reviewed
Jan 10, 2024
README.md
Outdated
| @@ -132,7 +132,7 @@ The following [dispatchers](./telemetry/producer.go#L10-L19) are supported | |||
| * ZMQ: Configure with the config.json file. See implementation here: [config/config.go](./config/config.go) | |||
| * Logger: This is a simple STDOUT logger that serializes the protos to json. | |||
|
|
|||
| >NOTE: To add a new dispatcher, please provide integration tests and updated documentation. | |||
| >NOTE: To add a new dispatcher, please provide integration tests and updated documentation. If you wish to send data to dispatcher in json instead protobuf, add a config `transmit_decoded_records` and set value to `true` as shown [here](config/test_configs_test.go#L104) | |||
There was a problem hiding this comment.
Lets not use "you" "your" "we" etc in documentation as it's less formal. This can be reworded to: "To serialize dispatcher data as json instead of protobufs, add a config transmit_decoded_records and set value to true as shown here"
agbpatro
force-pushed
the
allow_transmitting_decoded_messages
branch
from
03b0d2e to
9f48c1b
Compare
aaronpkahn
approved these changes
Jan 10, 2024
agbpatro
force-pushed
the
allow_transmitting_decoded_messages
branch
from
9f48c1b to
e29efc5
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allowing option to send messages to producers in json instead of proto. This way, consumers wont have to decode the protobuf message. Idea based on conversation #91 (comment)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: