Scan and pick first available hci device #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per more tests I just ran, when the device jumps from hci0 to hci1, when the kernel encounter an issue with the later, the device goes back to hci0. [edit] it even jumped once to hci2 and reverted later to hci0. Perhaps a better solution would be to allow via command line to specific which device to use but most people only have a single BLE device. |
baylanger
commented
Feb 2, 2025
| return nil, fmt.Errorf("failed to find available Bluetooth adapter: %w", err) | ||
| } | ||
|
|
||
| log.Printf("Using Bluetooth adapter: %s", hciName) |
There was a problem hiding this comment.
This should probably use log.Debug
|
Is there a reliable way to reproduce this on a raspberry Pi? I do most of my Linux-based testing on one and haven't encountered this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables
tesla-controlto automatically select, at least under Linux, the first availablehcidevice. Currently,tesla-controlonly tries to usehci0and lacks the ability to dynamically choose the first available Bluetooth device.In our project, an add-on for Home Assistant,
tesla-controlis used to fetch data and control Tesla vehicles.We’ve received multiple reports from different people seeing always the same issue. This happens on Raspberry Pi (recent and old models), Synology NAS, and similar systems. After a fresh reboot, the Bluetooth device initially appears as hci0, but after a short time, it jumps to hci1. After this,
tesla-controlbecomes useless.I am not a pro Go programmer but the tests I ran seem to be a solution for #261
Fixes #261
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: