Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send output of combine_tessdata -d to stdout instead of stderr. Fixes #4149 #4150

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

tfmorris
Copy link
Contributor

Fixes #4149.

Rather than sending the listing to stderr send it to stdout like is done for the network listing.

Also document the hidden -ld and -dl switch combos in the help message.

@zdenop
Copy link
Contributor

zdenop commented Oct 24, 2023

Thanks. In this context it would nice to finalize related issue #3998 and PR #4020

@zdenop zdenop merged commit eb612f0 into tesseract-ocr:main Oct 24, 2023
5 of 6 checks passed
@tfmorris tfmorris deleted the 4149-directory-to-stdout branch October 24, 2023 06:47
@tfmorris
Copy link
Contributor Author

Thanks for merging. I'm not sure what's wrong with the macOS test. It ran almost 6 hours before being killed. Whatever the problem was, it clearly wasn't anything to do with this PR.

In this context it would nice to finalize related issue #3998 and PR #4020

I think this case was a little more clear cut because it was the actual requested output which was being sent to stderr. I think distinguishing between levels of logging messages (debug, info, warn, error) as far as where they get sent is less clear. I don't use training enough to argue one way or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

combine_tessdata -d outputs to stderr instead of stdout
3 participants