Update to clang-tidy-17 on jammy (#449)

tesseract-robotics · Feb 12, 2025 · a9eed97 · a9eed97
1 parent a2f77bb
commit a9eed97
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 6 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -22,6 +22,7 @@ Checks: >
     -misc-include-cleaner,
     -misc-no-recursion,
     -misc-non-private-member-variables-in-classes,
+    -misc-const-correctness,
     modernize-*,
     -modernize-use-nodiscard,
     -modernize-use-trailing-return-type,
@@ -59,6 +60,7 @@ WarningsAsErrors: >
     -misc-include-cleaner,
     -misc-no-recursion,
     -misc-non-private-member-variables-in-classes,
+    -misc-const-correctness,
     modernize-*,
     -modernize-use-nodiscard,
     -modernize-use-trailing-return-type,

diff --git a/.github/workflows/package_debian.yml b/.github/workflows/package_debian.yml
@@ -63,7 +63,7 @@ jobs:
           apt install -y clang-tidy
 
       - name: Build and test
-        uses: tesseract-robotics/colcon-action@v9
+        uses: tesseract-robotics/colcon-action@v11
         with:
           before-script: source /opt/tesseract/install/setup.bash
           ccache-enabled: false

diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
@@ -59,7 +59,7 @@ jobs:
           path: target_ws/src
 
       - name: Build and Tests
-        uses: tesseract-robotics/colcon-action@v8
+        uses: tesseract-robotics/colcon-action@v11
         with:
           before-script: source /opt/tesseract/install/setup.bash
           ccache-prefix: ${{ matrix.distro }}

diff --git a/.github/workflows/unstable.yml b/.github/workflows/unstable.yml
@@ -16,6 +16,16 @@ jobs:
       fail-fast: false
       matrix:
         distro: [focal, jammy, noble]
+        include:
+          - distro: focal
+            env:
+              TARGET_CMAKE_ARGS: "-DCMAKE_BUILD_TYPE=Debug -DTRAJOPT_ENABLE_TESTING=ON -DTRAJOPT_ENABLE_CLANG_TIDY=ON -DTRAJOPT_PACKAGE=ON"
+          - distro: jammy
+            env:
+              TARGET_CMAKE_ARGS: "-DCMAKE_BUILD_TYPE=Debug -DTRAJOPT_ENABLE_TESTING=ON -DTRAJOPT_ENABLE_CLANG_TIDY=ON -DTRAJOPT_PACKAGE=ON -DCLANG_TIDY_NAMES=clang-tidy-17"
+          - distro: noble
+            env:
+              TARGET_CMAKE_ARGS: "-DCMAKE_BUILD_TYPE=Debug -DTRAJOPT_ENABLE_TESTING=ON -DTRAJOPT_ENABLE_CLANG_TIDY=ON -DTRAJOPT_PACKAGE=ON"
     container:
       image: ghcr.io/tesseract-robotics/tesseract:${{ matrix.distro }}-master
       env:
@@ -33,14 +43,26 @@ jobs:
         run: |
           apt update
           apt upgrade -y
-          apt install -y clang-tidy
+
+      - name: Install Clang Tidy
+        if: ${{ matrix.distro == 'jammy' }}
+        shell: bash
+        run: |
+          apt install -y wget
+          echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main" | tee /etc/apt/sources.list.d/llvm-toolchain.list
+          echo "deb-src http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main" | tee -a /etc/apt/sources.list.d/llvm-toolchain.list
+          wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | tee /etc/apt/trusted.gpg.d/llvm.asc
+          apt update -y
+          apt install -y clang-tidy-17 libomp-17-dev
 
       - name: Build and Tests
-        uses: tesseract-robotics/colcon-action@v8
+        uses: tesseract-robotics/colcon-action@v11
         with:
           before-script: source /opt/tesseract/install/setup.bash
           ccache-prefix: ${{ matrix.distro }}
           vcs-file: dependencies_unstable.repos
+          run-tests: false
+          rosdep-install-args: -iry --skip-keys=libomp-dev
           upstream-args: --cmake-args -DCMAKE_BUILD_TYPE=Release
           target-path: target_ws/src
-          target-args: --cmake-args -DCMAKE_BUILD_TYPE=Debug -DTRAJOPT_ENABLE_TESTING=ON -DTRAJOPT_ENABLE_CLANG_TIDY=ON -DTRAJOPT_PACKAGE=ON
+          target-args: --cmake-args ${{ matrix.env.TARGET_CMAKE_ARGS }}
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -56,7 +56,7 @@ jobs:
         echo "CMAKE_PREFIX_PATH=$GITHUB_WORKSPACE\vcpkg\installed\x64-windows-release" >> "$GITHUB_ENV"
 
     - name: Build and Tests
-      uses: tesseract-robotics/colcon-action@v4
+      uses: tesseract-robotics/colcon-action@v11
       with:
         ccache-prefix: ${{ matrix.distro }}
         vcs-file: .github/workflows/windows_dependencies.repos