Fix #346 - cleanup cache enabling #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Thomas <[email protected]>
thommay
approved these changes
Apr 24, 2018
coderanger
approved these changes
Apr 24, 2018
|
In forgetting to write tests it looks like this just breaks things a different way - will figure that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #346 but also radically simplifies the cache enabling code.
falseenable_cache?method, this wasn't really needed and made the logic more confusingcache_directoryis set by the user, we honor that firstI don't see any downsides to this one but given it's changing defaults would like to make sure I haven't missed something.
Signed-off-by: Seth Thomas [email protected]