Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simply config #159

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

stevenh
Copy link
Contributor

@stevenh stevenh commented Sep 7, 2024

Simplify the configuration so its easier to add new settings, clearer what the default values are and which environment variables impact the running of container.

This includes compatibility with slog for future use.

@stevenh stevenh requested a review from a team as a code owner September 7, 2024 09:59
Simplify the configuration so its easier to add new settings, clearer
what the default values are and which environment variables impact the
running of container.

This includes compatibility with slog for future use.

Bump version of golangci-lint so to prevent invalid failures
* main:
  fix: bump Go version in Dockerfiles (testcontainers#162)
  chore: bump versions (testcontainers#160)
main.go Show resolved Hide resolved
@mdelapenya mdelapenya self-assigned this Sep 25, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Sep 25, 2024
mdelapenya
mdelapenya previously approved these changes Sep 30, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'd like to double check with you the need of logging the config right after it's loaded (if verbose)

config.go Show resolved Hide resolved
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 8aef324 into testcontainers:main Sep 30, 2024
9 checks passed
@stevenh stevenh deleted the chore/simplify-config branch September 30, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants