wip: move non-legacy tags to the top

modules/localstack/localstack.go

@@ -20,6 +20,13 @@ const (
 	localstackHostEnvVar   = "LOCALSTACK_HOST"
 )
 
+var nonLegacyTags = []string{
+	"latest",
+	"s3",
+	"s3-latest",
+	"stable",
+}
+
 func isLegacyMode(image string) bool {
 	parts := strings.Split(image, ":")
 	version := parts[len(parts)-1]
@@ -28,8 +35,10 @@ func isLegacyMode(image string) bool {
 		version = version[0:pos]
 	}
 
-	if version == "latest" || version == "s3" || version == "s3-latest" || version == "stable" {
-		return false
+	for _, tag := range nonLegacyTags {
+		if version == tag {
+			return false
+		}
 	}
 
 	if !strings.HasPrefix(version, "v") {