Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve AWS deprecations for localstack #2879

Merged
merged 5 commits into from
Nov 7, 2024
Merged

chore: resolve AWS deprecations for localstack #2879

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1101aac
fix: resolve AWS deprecations for localstack
mdelapenya Oct 25, 2024
f3e785c
docs: include resolver
mdelapenya Nov 6, 2024
cbc7016
chore: simplify fmt.Sprintf
mdelapenya Nov 6, 2024
9f5ead3
fix: proper format
mdelapenya Nov 7, 2024
4344ab2
fix: remove unused import
mdelapenya Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/localstack/v2/s3_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@

// reference: https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/endpoints/#with-both
client := s3.NewFromConfig(awsCfg, func(o *s3.Options) {
o.BaseEndpoint = aws.String(fmt.Sprintf("http://%s:%d", host, mappedPort.Int()))
o.BaseEndpoint = aws.String("http://"+ host +":"+ mappedPort.Port()))

Check failure on line 71 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.22.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.22.x 

expected statement, found ')' (typecheck)

Check failure on line 71 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.x 

expected statement, found ')' (typecheck)
mdelapenya marked this conversation as resolved.
Show resolved Hide resolved
o.EndpointResolverV2 = &resolverV2{}
o.UsePathStyle = true
})

return client, nil
}

Check failure on line 77 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.22.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.22.x 

missing ',' before newline in argument list (typecheck)

Check failure on line 77 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.x 

missing ',' before newline in argument list (typecheck)

// }

func TestS3(t *testing.T) {

Check failure on line 81 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.22.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.22.x 

expected '(', found TestS3 (typecheck)

Check failure on line 81 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.x 

expected '(', found TestS3 (typecheck)
ctx := context.Background()

ctr, err := localstack.Run(ctx, "localstack/localstack:1.4.0")
Expand Down Expand Up @@ -136,4 +136,4 @@
assert.Equal(t, aws.Int64(int64(len(body1))), objects[0].Size)
})
})
}

Check failure on line 139 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.22.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.22.x 

missing ',' before newline in argument list (typecheck)

Check failure on line 139 in modules/localstack/v2/s3_test.go

View workflow job for this annotation

GitHub Actions / test-modules (1.x, ubuntu-latest, localstack) / modules/localstack/ubuntu-latest/1.x 

missing ',' before newline in argument list (typecheck)
Loading