fix: typos #2940
Open
fix: typos #2940
+138
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
requested changes
Jan 11, 2025
| @@ -555,7 +555,9 @@ func (p *DockerProvider) preCreateContainerHook(ctx context.Context, req Contain | |||
| } | |||
| req.HostConfigModifier(hostConfig) | |||
|
|
|||
| if req.EnpointSettingsModifier != nil { | |||
| if req.EndpointSettingsModifier != nil { | |||
There was a problem hiding this comment.
suggestion: let's just make the correction and mark as a breaking change
There was a problem hiding this comment.
Sure, do I need to change this PR title's prefix to fix!:?
There was a problem hiding this comment.
I would @mdelapenya thoughts?
| @@ -53,7 +53,9 @@ func (m *mockReaperProvider) RunContainer(ctx context.Context, req ContainerRequ | |||
| } | |||
| req.HostConfigModifier(m.hostConfig) | |||
|
|
|||
| if req.EnpointSettingsModifier != nil { | |||
| if req.EndpointSettingsModifier != nil { | |||
There was a problem hiding this comment.
suggestion: as mentioned above let's just make the breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bunch of typos.
Why is it important?
Improves readability and professionalism.
The top typos are: