Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow enabling jetstream for nats #268

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

cedricziel
Copy link
Contributor

NATS has a built-in persistence engine called JetStream which enables messages to be stored and replayed at a later time.

https://docs.nats.io/nats-concepts/jetstream

NATS has a built-in persistence engine called JetStream which enables messages to be stored and replayed at a later time.

https://docs.nats.io/nats-concepts/jetstream
Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🚀

Looks good to me, but just one comment

src/nats/mod.rs Outdated Show resolved Hide resolved
@cedricziel cedricziel requested a review from DDtKey January 13, 2025 09:31
@cedricziel
Copy link
Contributor Author

@DDtKey I added a small blurb about the JetStream feature in NATS - let me know if that works :)

@cedricziel
Copy link
Contributor Author

I think the test fails because a different module, not because of the changes in this PR

@DDtKey
Copy link
Contributor

DDtKey commented Jan 13, 2025

Yes, gitea module seems to be flaky. That will be fixed separately
Thank you for the contribution!

@DDtKey DDtKey merged commit d4a6151 into testcontainers:main Jan 13, 2025
9 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Jan 27, 2025
DDtKey pushed a commit that referenced this pull request Jan 27, 2025
## 🤖 New release
* `testcontainers-modules`: 0.11.5 -> 0.11.6 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.11.6] - 2025-01-27

### Features

- Allow enabling jetstream for nats (#268)
- Add Foundry Anvil image impl (#272)
- Add method `latest` to anvil node impl (#277)

### Testing

- Fix broken test in CI (#281)

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants