Support limit and offset in all_ functions
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-lozano
force-pushed
the
allow_limit_in_all
branch
from
bcf456a to
f76bf9f
Compare
Add additional option support for limits and offsets. Also refactored to use a reduce as it makes it easier to only apply query changes for options that are present.
joseph-lozano
force-pushed
the
allow_limit_in_all
branch
from
f76bf9f to
6f8081f
Compare
joseph-lozano
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off of #30 since I'm using both changes, but this could easily be pointed at main.
Does two things:
1. Refactors the option parsing in
allto use a reduce. This makes it a bit easier to options that don't have an easy default (likewhere: []) since it will only apply options that are present.2. Adds support for
:limitand:offsetoptions.