Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test against svelte v3 and v4 #295

Merged
merged 1 commit into from
Jan 29, 2024
Merged

ci: test against svelte v3 and v4 #295

merged 1 commit into from
Jan 29, 2024

Conversation

mcous
Copy link
Collaborator

@mcous mcous commented Jan 27, 2024

Overview

This is the second PR in a series to add multiple Svelte versions and test runners to our CI test matrix.

  1. feat(vitest): add vitest cleanup export #294
  2. ci: test against svelte v3 and v4 #295 <-- you are here
  3. ci: run vitest on jsdom and happy-dom #297
  4. TODO add Jest to CI matrix

Change log

This PR updates the CI test matrix to install different Svelte versions prior to testing

  • Replace third party action with npm install for flexibility and security
  • Call npm install svelte with a specific version in CI from the matrix
  • Update action dependencies to remove CI warnings
    • cycjimmy/semantic-release-action needs an update too, but I'd like to leave release stuff to its own PR in case of issues

@mcous mcous marked this pull request as draft January 27, 2024 10:41
@mcous mcous marked this pull request as ready for review January 27, 2024 20:35
strategy:
matrix:
node: [16, 18, 20]
node: ['16', '18', '20']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably drop Node v16 from the CI matrix, but I'd rather leave that for a breaking change release. I'm pretty sure there's one on the horizon for the rerender stuff, at least

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can drop it when the reports get too cumbersome. Till then, more data is always nice.

@yanick yanick merged commit 10259aa into testing-library:main Jan 29, 2024
9 checks passed
@mcous mcous deleted the ci-multiple-svelte branch January 29, 2024 18:11
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants