Allow to update stateful sets and restart pods with custom annotations #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controllers/spec/enforcer/statefulset_spec/CustomMetadataSpecEnforcer.go
Outdated
Show resolved
Hide resolved
controllers/spec/enforcer/statefulset_spec/CustomMetadataSpecEnforcer.go
Outdated
Show resolved
Hide resolved
gonzaloserrano
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be external reasons to Kubegres that would require restart on stateful set pods.
This PR allows to cause updates on the stateful set, and pod restarts, by updating the Kubgres CR with
kubegres.reactive-tech.io/prefixed annotations.The initial implementation did not consider custom annotations or label changes requiring stateful set update, it was only adding them at creation time.
The reason might be that other external integrations that label the resources for their own management (like Calico) will not cause DB restarts.
For this reason, only the
kubegres.reactive-tech.io/prefixed labels or annotations will be propagated causing the DB restart.This is useful in the case you manually added TLS support to the DB. Because you can trigger a DB restart as soon you detect a TLS expiration/invalidation and a new one is created.