Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regalloc: simplifies findOrSpillAllocatable #2267

Merged
merged 3 commits into from
Jun 25, 2024
Merged

regalloc: simplifies findOrSpillAllocatable #2267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0dd478
regalloc: simplifies findOrSpillAllocatable
mathetake Jun 25, 2024
9dc5926
fix
mathetake Jun 25, 2024
355b90d
fix
mathetake Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions internal/engine/wazevo/backend/regalloc/regalloc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,7 @@ func (a *Allocator[I, B]) findOrSpillAllocatable(s *state[I, B], allocatable []R
r = RealRegInvalid
// First, check if the preferredMask has any allocatable register.
if preferred != RealRegInvalid && !forbiddenMask.has(preferred) && !s.regsInUse.has(preferred) {
for _, candidateReal := range allocatable {
// TODO: we should ensure the preferred register is in the allocatable set in the first place,
// but right now, just in case, we check it here.
if candidateReal == preferred {
return preferred
}
}
return preferred
}

var lastUseAt programCounter
Expand Down
Loading