Support fd_sync
for stdout/stderr writers via optional interface
#2359
+75
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, when an arbitrary
io.Writer
is passed for the module's stdout/stderr, it's not possible to hook intofd_sync
when it is called on the respective file descriptor.I've extended
writerFile
struct to attempt to call aSync
method on the inner writer interface, if it passes the type assertion.My use case is as follows:
WithStdout
, I'm passing in a wrapperhttp.ResponseWriter
.os.Stdout.Sync()
I want to invokehttp.Flusher.Flush()
on the guest.As long as the writer decides to implement this simple interface:
The host can hook into whenever the client flushes the fd.
Also, thanks for this amazing project, I've been meaning to dive into wazero ever since I saw Takeshi's talk at GopherCon '22 in person 😄