Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Make command to run tests with coverage #594

Closed
wants to merge 1 commit into from

Conversation

anuraaga
Copy link
Contributor

I think it can be helpful to be able to check out coverage locally when writing tests so use this command for that. We could consider publishing to codecov in the future if` it seems useful.

@anuraaga anuraaga force-pushed the unit-test-coverage branch from 929e136 to 0c49ecc Compare May 27, 2022 08:06
@codefromthecrypt
Copy link
Contributor

probably sensible to start migrating in things from func-e vs slowly and differently introducing them here. We spent a good deal of time on the makefile there, including making sure there was re-use of expressions and that things work on windows.

Do you mind migrating in the coverage related stuff instead? The choices in the "coverage" target were made to allow use of code cov as a sort of coverage IDE without the spam. Please also add the "clean" target stuff, if you don't mind.

https://github.com/tetratelabs/func-e/blob/master/.github/workflows/commit.yaml#L88-L96
https://github.com/tetratelabs/func-e/blob/master/.gitignore#L2
https://github.com/tetratelabs/func-e/blob/master/Makefile#L85-L90

After this, it should be more clear where to start for adding more tools to the build, and yeah I think we spent several months so might as well start ahead!

@anuraaga anuraaga closed this May 27, 2022
@codefromthecrypt
Copy link
Contributor

#596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants