Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for highlighting non-English commit messages #60

Open
walles opened this issue Sep 27, 2021 · 0 comments
Open

Support for highlighting non-English commit messages #60

walles opened this issue Sep 27, 2021 · 0 comments

Comments

@walles
Copy link

walles commented Sep 27, 2021

Please add support for highlighting non-English commit messages, see example below.

Right now, the diff part gets no highlighting. What I expect is to see added lines in green and removed lines in red.


# Ange incheckningsmeddelandet för dina ändringar. Rader som inleds
# med "#" kommer ignoreras, och ett tomt meddelande avbryter incheckningen.
#
# På grenen main
# Ändringar att checka in:
#	ändrad:        hej
#
# ------------------------ >8 ------------------------
# Raden ovan får inte ändras eller tas bort.
# Allt under den kommer tas bort.
diff --git hej hej
index 257cc56..5716ca5 100644
--- hej
+++ hej
@@ -1 +1 @@
-foo
+bar

I initially intended to do this myself but got stuck on #59.

walles added a commit to walles/vscode that referenced this issue Sep 27, 2021
This grammar has not been updated since 2016:
https://github.com/textmate/git.tmbundle/blob/master/Syntaxes/Git%20Commit%20Message.tmLanguage

The upstream test suite requires running a Ruby version that has been
EOL since 2014, and that I failed to build on macOS:
textmate/git.tmbundle#59

If this change is accepted, my plan is to add support to vscode for
highlighting non-English commit messages:
textmate/git.tmbundle#60

And even if I never get around to that, this at least opens up the
possibility for somebody else to do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant