Adds bloodthirster Rav strain #16664

TiviPlus · 2024-10-12T23:03:57Z

About The Pull Request

Numbers are REALLY in doubt

Adds the bloodthirster rav strain, intended to lean more into the aggressive risk taking that rav does

Bloodthirster has the bloodthirst mechanic, which more or less means it only gets plasma through slashes, plasma decays when not attacking enemies, and not attacking for a while deals damage to you until you're down to 100hp
But if you deal damage you get longer ranges and stronger charge and ravage, and rage speed bonus is multiplied

Primo:
Deathmark
Mark yourself for death, deal 400 damage in 40 seconds or die but you get speed buffs and full rage for the duration

Why It's Good For The Game

variety or something

Changelog

🆑
add: Added the bloodthirster ravager strain, which takes damage when not dealing damage, but gets buffs from dealing a lot of damage
/:cl:

Naaanii · 2024-10-12T23:54:37Z

Holy based...

Xander3359 · 2024-10-13T00:32:39Z

Captain, another ravager has hit the ground side.

demir-pl · 2024-10-13T03:27:08Z

now this is a GOOD PR (speedmerge NOW)
design good - idea amazing - more combat? FANTASTIC love that

thinking about stats i would love to suggest:

-max health would be nice but maybe that's too much? - 500/550?
maybe make bloodthirst level increase health + sunder multi? instead of just plasma (more rewards for damage)
-raising bomb armor to 20 25 so you don't get 1 shot by sadars or can take few nades, maybe make make bomb armor/armor grow with bloodthirst
-important would be raising endure health (i would say up to -150/200 health instead of -100)
-raising the bloodthirst decay health to a reasonable 150? so you aren't a sitting duck for a sniper

also if he is meant to be more combat focused (he will die without dealing damage its combat to the max) i ask (demand) for ability cooldown change - i would say 50% compared to base rav (30 seconds instead of 60 on endure/rage - 10 seconds on charge - ravage to 5 seconds?)

last note would be testing how possible is 400 damage in 40 seconds (probably moderate difficulty but who knows...)

but that's just my dumb thoughts without knowledge/testing

HOLY SHIT THIS SOUNDS SO GOOD AUGH!!!! TIME TO GET 1 TAPPED OFF SCREEN BY REQ SLOP WITH NO COUNTER!!! WOOO HOOO!!!!!!!!!! (jk actually loving it)

DrAmazing343 · 2024-10-13T08:09:02Z

I like the idea but ultimately I think aside from a cooldown reduction we gotta be reaaaal careful with the numbers. Really good normal ravs are super fucking hard to kill, but also solo murder machines. This would turn those ravs into genuinely unkillable colombian murder machines on crack.

iforgotmeword · 2024-10-13T12:20:07Z

i say bump that min HP to like 180 or something like that
100HP for a rav (big target) is not much
also any change in it's sprites?

also also do something for when high jacking being stuck with min HP because you killed all of the marines shouldn't be a thing

also also also death mark seems busted? 40 secs is a very long time

Arturlang · 2024-10-13T12:35:12Z

Current normal rav isn't really in a good spot right now, doesn't feel like it competes with the other buffed xenos all that well, would be fun to see how this one works out.
Rav in general has really needed extra endure health as most things will just pop you before you can do anything, relegating endure/rage to a escape tool.

Arturlang · 2024-10-13T12:44:09Z

code/modules/mob/living/carbon/xenomorph/castes/ravager/abilities_ravager.dm

+	xeno.emote("roar")
+
+/// on attack for deathmark, tracks the amount of dmg dealt
+/datum/action/ability/xeno_action/deathmark/proc/on_attack(datum/source, mob/living/attacked, damage)


So, assuming that the rav only really slashes to try to fulfill deathmark's 400 damage threshold, as COMSIG_XENOMORPH_ATTACK_LIVING outputs xeno's slash damage times whatever damage modifier it has, but I'll just assume it's 25 as it usually is, 400/25, means you need to do 16 slashes to not die, which means you'd probably have to kill two marines just to not die, unless they're incredibly tanky because of tyr 2.
Though i'm not really accounting for charge as that can multihit easily

tbh 16 slashes isn't that much but might get fucky if you're focused - but full rage is really good since you well.. have full rage - FULL HEAL + temp sunder(like rage) would also be huge, but it might be bit far (but it is primo ability after all)

Means you have 2.5 seconds to do each slash or you'll simply run out of time.

Think that 40 seconds is doable since you can slash prerty fast but only tm can show us - also timer in some way would be good - maybe same as time until endure/rage runs out? Screen effects too maybe? Or maybe a glowy aura changing on time - something so you aren't surprised how fast 40 seconds passed

Just use the screen timer thingy or do a similar thing on the mob itself

…omments

code/modules/mob/living/carbon/xenomorph/castes/ravager/abilities_ravager.dm

Lumipharon · 2024-10-17T00:33:31Z

code/modules/mob/living/carbon/xenomorph/castes/ravager/abilities_ravager.dm

+
+/datum/action/ability/xeno_action/bloodthirst
+	name = "bloodthirst"
+	desc = "tivi todo"


Lumipharon · 2024-10-17T00:33:59Z

code/modules/mob/living/carbon/xenomorph/castes/ravager/abilities_ravager.dm

+/datum/action/ability/xeno_action/bloodthirst/proc/on_attack(datum/source, mob/living/attacked, damage)
+	SIGNAL_HANDLER
+	if(!ishuman(attacked) || attacked.stat == DEAD)
+		return
+	last_fight_time = world.time
+
+/datum/action/ability/xeno_action/bloodthirst/proc/on_take_damage(datum/source, damage)
+	SIGNAL_HANDLER
+	last_fight_time = world.time


autodoc and in the wrong place

Lumipharon · 2024-10-17T00:36:33Z

code/modules/mob/living/carbon/xenomorph/castes/ravager/castedatum_ravager.dm

+	var/plasma_damage_dealt_mult = 1.5
+	var/plasma_damage_recieved_mult = 0.5


Pariah919 · 2024-10-17T09:05:18Z

wait the ravage and endure are 0 cost? what's the point of plasma?
This generally seems like a straight upgrade.

Lumipharon · 2024-10-17T22:05:50Z

code/modules/mob/living/carbon/xenomorph/xeno_helpers.dm

+/mob/living/carbon/xenomorph/get_crit_threshold()
+	. = ..()
+	if(!endure)
+		return
+	var/datum/action/ability/xeno_action/endure/endure_ability = actions_by_path[/datum/action/ability/xeno_action/endure]
+	return endure_ability.endure_threshold
+
 /mob/living/carbon/xenomorph/get_death_threshold()
-	return xeno_caste.crit_health
+	if(!endure)
+		return xeno_caste.crit_health
+	var/datum/action/ability/xeno_action/endure/endure_ability = actions_by_path[/datum/action/ability/xeno_action/endure]
+	return endure_ability.endure_threshold


maybe out of scope, but all these funny xeno mob action checks should presumably be handled via signals

Lumipharon · 2024-10-17T22:08:08Z

Also xenos still can't strainswap themselves, and normal ravs come up as bloodthirsters in the hive list

code/modules/mob/living/carbon/xenomorph/castes/ravager/abilities_ravager.dm

…ies_ravager.dm

Lumipharon · 2024-10-18T01:31:36Z

code/modules/mob/living/carbon/xenomorph/castes/ravager/abilities_ravager.dm

@@ -735,3 +737,4 @@
 	xeno.playsound_local(xeno, 'sound/voice/hiss5.ogg', 50)
 	to_chat(owner, span_highdanger("THE QUEEN MOTHER IS PLEASED WITH YOUR PERFORMANCE ([damage_dealt]/[DEATHMARK_DAMAGE_OR_DIE])."))
 	owner.balloon_alert(owner, "deathmark expired")
+	add_cooldown()


we need a cooldown on use

AndroidMK2 · 2024-10-18T10:25:10Z

How long until the damage taking from not slashing kicks in?

Admiral-Gigaton · 2024-10-18T20:17:40Z

v1 from ultrakill joined the xenos

github-actions · 2024-10-26T00:50:25Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions · 2024-11-03T00:55:49Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Adds bloodthirster

9fc66c0

tgstation-server added Sprites Changes to .dmi file. Feature New interesting mechanics with new interesting bugs labels Oct 12, 2024

Arturlang reviewed Oct 13, 2024

View reviewed changes

Kuro020 approved these changes Oct 13, 2024

View reviewed changes

TiviPlus added 3 commits October 13, 2024 20:37

No decay until first enemy attacked + no ability bloodthirst cost + c…

ba03662

…omments

Actually commit changes

68c6461

Tweak bloodthirst thresholds

8efa6ca

Lumipharon requested changes Oct 17, 2024

View reviewed changes

Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024

comfyorange added a commit that referenced this pull request Oct 17, 2024

TGS Test Merge (#16664)

a1c291c

Fixes

1ebe188

tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024

Lumipharon reviewed Oct 17, 2024

View reviewed changes

Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024

comfyorange added a commit that referenced this pull request Oct 17, 2024

TGS Test Merge (#16664)

f843551

Lumipharon reviewed Oct 17, 2024

View reviewed changes

code/modules/mob/living/carbon/xenomorph/castes/ravager/abilities_ravager.dm Outdated Show resolved Hide resolved

Update code/modules/mob/living/carbon/xenomorph/castes/ravager/abilit…

a2313f7

…ies_ravager.dm

tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024

comfyorange added a commit that referenced this pull request Oct 17, 2024

TGS Test Merge (#16664)

b58946c

Lumipharon reviewed Oct 18, 2024

View reviewed changes

github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Oct 26, 2024

TiviPlus removed the Stale Pull request is awaiting delayed author response and may be closed. label Oct 26, 2024

Fixes

4b1459f

github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 3, 2024

github-actions bot closed this Nov 7, 2024

TiviPlus reopened this Nov 7, 2024

TiviPlus removed the Stale Pull request is awaiting delayed author response and may be closed. label Nov 7, 2024

fix deathmark cd

247bf54

Lumipharon approved these changes Nov 12, 2024

View reviewed changes

Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds bloodthirster Rav strain #16664

Adds bloodthirster Rav strain #16664

TiviPlus commented Oct 12, 2024 •

edited by github-actions bot

Loading

Naaanii commented Oct 12, 2024

Xander3359 commented Oct 13, 2024

demir-pl commented Oct 13, 2024

DrAmazing343 commented Oct 13, 2024

iforgotmeword commented Oct 13, 2024 •

edited

Loading

Arturlang commented Oct 13, 2024 •

edited

Loading

Arturlang Oct 13, 2024 •

edited

Loading

demir-pl Oct 13, 2024

Arturlang Oct 15, 2024

demir-pl Oct 16, 2024

Arturlang Oct 18, 2024

Lumipharon Oct 17, 2024

Lumipharon Oct 17, 2024

Lumipharon Oct 17, 2024

Pariah919 commented Oct 17, 2024 •

edited

Loading

Lumipharon Oct 17, 2024

Lumipharon commented Oct 17, 2024

Lumipharon Oct 18, 2024

AndroidMK2 commented Oct 18, 2024

Admiral-Gigaton commented Oct 18, 2024

github-actions bot commented Oct 26, 2024

github-actions bot commented Nov 3, 2024

		var/plasma_damage_dealt_mult = 1.5
		var/plasma_damage_recieved_mult = 0.5

Adds bloodthirster Rav strain #16664

Are you sure you want to change the base?

Adds bloodthirster Rav strain #16664

Conversation

TiviPlus commented Oct 12, 2024 • edited by github-actions bot Loading

About The Pull Request

Why It's Good For The Game

Changelog

Naaanii commented Oct 12, 2024

Xander3359 commented Oct 13, 2024

demir-pl commented Oct 13, 2024

DrAmazing343 commented Oct 13, 2024

iforgotmeword commented Oct 13, 2024 • edited Loading

Arturlang commented Oct 13, 2024 • edited Loading

Arturlang Oct 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pariah919 commented Oct 17, 2024 • edited Loading

Choose a reason for hiding this comment

Lumipharon commented Oct 17, 2024

Choose a reason for hiding this comment

AndroidMK2 commented Oct 18, 2024

Admiral-Gigaton commented Oct 18, 2024

github-actions bot commented Oct 26, 2024

github-actions bot commented Nov 3, 2024

TiviPlus commented Oct 12, 2024 •

edited by github-actions bot

Loading

iforgotmeword commented Oct 13, 2024 •

edited

Loading

Arturlang commented Oct 13, 2024 •

edited

Loading

Arturlang Oct 13, 2024 •

edited

Loading

Pariah919 commented Oct 17, 2024 •

edited

Loading