Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tg examine/chat ports, readability changes to dsay/ooc/xeno/admin spans #16732

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

Neocloudy
Copy link
Contributor

@Neocloudy Neocloudy commented Nov 10, 2024

Testmerge before I break everything in existence. Will probably have issues, this is a large PR and it's a few weeks old by now.

About The Pull Request

Examine Refactor

tgstation/tgstation#86678
tgstation/tgstation#86506

  • Splits atom examine functionality into its own file. I will split the rest of atoms.dm up eventually >:)
  • Ports examine_tags, examine_descriptors and their signals from TG, for examine tags you supply an assoc list of NAME -> TOOLTIP, these pop out when examining atoms.
  • Examine descriptors are just descriptors like "object" "item" "clothing item" etc.
    • These can be used to save time (less codex visits) and show more information easily. If you want to know more, you can hover.
    • There are tags for things being invulnerable/vulnerable to xeno attacks/abilities, invulnerable to everything, etc. Tags for xeno stuff (except acidproof, that's relevant to humans) will only show up for observers/xenos: you can use the codex to find these as a person.
    • Some examples:
      image
      image
      image
  • Ports fieldset blocks, separators, etc from TG, for more robust examine blocks
    image
    image
    image

Deadchat, OOC, admin PM updates

OOC and OOC alerts are now yellow, hopefully more readable like this. Deadchat is a lighter color, closer to Paradise/TG while still being different from the default chat color. Xeno notice/warning are lighter.

Admin/Mentor OOC colors have also been adjusted to use TG's colors. Applies to asay, msay, and admin/mentor PMs too.

image
image
image

image
image
image

weight_class_data

Adds a new proc, weight_class_data, returns an assoc list of text -> tooltip. Used for weight class descriptions in examine tags. (I should port this to TG and fix the bugs they have with this)

Why It's Good For The Game

Makes examine more consistent, hopefully much better looking- generally just giving it a pass after a long time of no adjustments.

I swear tooltips not looking special in chat was an oversight or something. Either way it's a good thing to have, and now we can be sure it's working.

Also, more readable chat colors. Ivanmixo seemed to want a more readable OOC alert color. While I was at it, I made OOC the same and gave the deadchat/xenonotice/xenowarning colors adjustments.

Picture of a Cat Smoking a Cigarette

cigge

Changelog

🆑
refactor: examine has been refactored. please report issues on the github
add: examine tags when examining things. you can hover over them for a tooltip
add: examine tags exist for lots of states, some examples are item conductivity, mask hugger protection, object vulnerability/invulnerability (xeno attacks/bombs/acid, etc)
add: most/all things that use examine blocks have received style changes. (roundstart tip, etc)
add: ooc, ooc announcements are yellow
add: new style for spawning in as a job
add: xeno chat styles are lighter (notice, warning, danger, highdanger, announce)
add: deadchat is a lighter color
add: admin/mentor pms updated to look like tg pms
add: tooltips in chat are more obvious, with a dotted underline and italicized text
qol: flavor text now appears closer to the bottom of the examine message when you examine humans
/:cl:

…lly lots of changes for everything examine/examine block related

- Flavor text is closer to the bottom of human examine again
- Tooltips in chat stand out more
- Yellow OOC. Good luck
- Also defines for OOC alerts
@tgstation-server tgstation-server added Refactor Improves underlying code to make systems more modular and functional. Feature New interesting mechanics with new interesting bugs UI We make things worse, but rounder labels Nov 10, 2024
@jonash07
Copy link
Contributor

Liberals KILLING the soul blue ooc color, smh smh
Anyways good pr

@Neocloudy Neocloudy changed the title tg examine/chat ports, readability changes to dsay/ooc/ooc/xeno alerts tg examine/chat ports, readability changes to dsay/ooc/xeno/admin spans Nov 12, 2024
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 14, 2024
comfyorange added a commit that referenced this pull request Nov 14, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 15, 2024
comfyorange added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Refactor Improves underlying code to make systems more modular and functional. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants