-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tg examine/chat ports, readability changes to dsay/ooc/xeno/admin spans #16732
Open
Neocloudy
wants to merge
19
commits into
tgstation:master
Choose a base branch
from
Neocloudy:examine-refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+458
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly lots of changes for everything examine/examine block related - Flavor text is closer to the bottom of human examine again - Tooltips in chat stand out more - Yellow OOC. Good luck - Also defines for OOC alerts
tgstation-server
added
Refactor
Improves underlying code to make systems more modular and functional.
Feature
New interesting mechanics with new interesting bugs
UI
We make things worse, but rounder
labels
Nov 10, 2024
Liberals KILLING the soul blue ooc color, smh smh |
Neocloudy
changed the title
tg examine/chat ports, readability changes to dsay/ooc/ooc/xeno alerts
tg examine/chat ports, readability changes to dsay/ooc/xeno/admin spans
Nov 12, 2024
TiviPlus
added
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Nov 14, 2024
comfyorange
added a commit
that referenced
this pull request
Nov 14, 2024
tgstation-server
removed
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Nov 15, 2024
comfyorange
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testmerge before I break everything in existence. Will probably have issues, this is a large PR and it's a few weeks old by now.
About The Pull Request
Examine Refactor
tgstation/tgstation#86678
tgstation/tgstation#86506
examine_tags
,examine_descriptors
and their signals from TG, for examine tags you supply an assoc list of NAME -> TOOLTIP, these pop out when examining atoms.Deadchat, OOC, admin PM updates
OOC and OOC alerts are now yellow, hopefully more readable like this. Deadchat is a lighter color, closer to Paradise/TG while still being different from the default chat color. Xeno notice/warning are lighter.
Admin/Mentor OOC colors have also been adjusted to use TG's colors. Applies to asay, msay, and admin/mentor PMs too.
weight_class_data
Adds a new proc,
weight_class_data
, returns an assoc list oftext
->tooltip
. Used for weight class descriptions in examine tags. (I should port this to TG and fix the bugs they have with this)Why It's Good For The Game
Makes examine more consistent, hopefully much better looking- generally just giving it a pass after a long time of no adjustments.
I swear tooltips not looking special in chat was an oversight or something. Either way it's a good thing to have, and now we can be sure it's working.
Also, more readable chat colors. Ivanmixo seemed to want a more readable OOC alert color. While I was at it, I made OOC the same and gave the deadchat/xenonotice/xenowarning colors adjustments.
Picture of a Cat Smoking a Cigarette
Changelog
🆑
refactor: examine has been refactored. please report issues on the github
add: examine tags when examining things. you can hover over them for a tooltip
add: examine tags exist for lots of states, some examples are item conductivity, mask hugger protection, object vulnerability/invulnerability (xeno attacks/bombs/acid, etc)
add: most/all things that use examine blocks have received style changes. (roundstart tip, etc)
add: ooc, ooc announcements are yellow
add: new style for spawning in as a job
add: xeno chat styles are lighter (notice, warning, danger, highdanger, announce)
add: deadchat is a lighter color
add: admin/mentor pms updated to look like tg pms
add: tooltips in chat are more obvious, with a dotted underline and italicized text
qol: flavor text now appears closer to the bottom of the examine message when you examine humans
/:cl: