Fire and liquid turf jump/throw interaction fixes #17027
+48
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiviPlus
added
Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Maybe TM this first. I checked through the stop_throw signal related procs and it should all be fine, but its possible I missed some weird interaction.
Throwing items across lava will no longer burn them.
Thrown things will no longer visually submerge mid throw
Jumping (or being thrown into) fire or liquid turfs (water/lava) will now instantly proc the relevant effects.
Generally a small refactor/cleanup for liquid turf procs, to make the code a bit cleaner and reusable.
Why It's Good For The Game
Bug fixes.
Changelog
🆑
fix: fixed items being burnt by lava while mid throw
fix: fixed things visually submerging mid throw
fix: fixed mobs not being immediately ignited when landing in fire/lava
/:cl: