Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwatch cleanup #17044

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Overwatch cleanup #17044

merged 3 commits into from
Feb 9, 2025

Conversation

Lumipharon
Copy link
Contributor

@Lumipharon Lumipharon commented Feb 5, 2025

About The Pull Request

Cleans up the nightmare that was the overwatch console dm file.

  1. Main change is splitting out overwatch consoles between 'military' consoles (i.e. the standard ones), and camera only consoles that lack all the CIC features (i.e. peanut gallery req/medical ones).
  2. Overwatch consoles now have both railgun and OB access (instead of squad consoles having railgun only, and main console having OB only).
  3. Fixed SOM overwatch consoles not actually counting roles because it was hard coded.
  4. Greatly cleaned up the code, splitting it out into a few extra files.
  5. Huge number of various misc code improvements.

This should really be TGUI but uh, I can't be assed with that agony, so at least this is an improvement, and should be less awful to try TGUI-ify in the future.

Why It's Good For The Game

doctors have no business swapping out SL's and firing the railgun etc.

Code improvement good.

Changelog

🆑
balance: Non CIC overwatch consoles no longer have military functions
code: cleaned up Overwatch console code
/:cl:

@spookydonut spookydonut closed this Feb 6, 2025
@spookydonut spookydonut reopened this Feb 6, 2025
@TiviPlus TiviPlus added Code Improvement Changes for adhering to code standards and codebase maintainability. Balance Changes to functionality that modifies how effective certain methods are at powergaming. labels Feb 9, 2025
@TiviPlus TiviPlus merged commit e4fefe5 into tgstation:master Feb 9, 2025
82 checks passed
github-actions bot added a commit that referenced this pull request Feb 9, 2025
@Lumipharon Lumipharon deleted the overwatch_changes branch February 11, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming. Code Improvement Changes for adhering to code standards and codebase maintainability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants