Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

64 bit lib detection #202

Merged
merged 2 commits into from
Feb 5, 2025
Merged

64 bit lib detection #202

merged 2 commits into from
Feb 5, 2025

Conversation

ZeWaka
Copy link
Collaborator

@ZeWaka ZeWaka commented Jan 19, 2025

for opendream

@amylizzle
Copy link
Contributor

voicing my support for librust_g64.so and rust_g64.dll

alexkar598
alexkar598 suggested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is fine

dmsrc/main.dm Outdated Show resolved Hide resolved
@Absolucy
Copy link
Contributor

tg already uses librustg_64.dll and rust_g64.dll anyways: tgstation/tgstation#87313

@ZeWaka
Copy link
Collaborator Author

ZeWaka commented Jan 21, 2025

tg already uses librustg_64.dll and rust_g64.dll anyways: tgstation/tgstation#87313

Yes, that's why I chose these names, so they could stop being out of compliance with the rustg.dm

@ZeWaka ZeWaka merged commit 09a94ca into master Feb 5, 2025
4 checks passed
@ZeWaka ZeWaka deleted the 64-bit-lib-support branch February 6, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkar598 alexkar598 alexkar598 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeWaka @amylizzle @Absolucy @alexkar598