[516 ONLY] Add gap prop & replace Stack.Item margin with Stack gap #70
+17
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
It's all said in the title. Adds props responsible for: column-gap, row-gap & gap.
This PR is fully uncompatible with Byond 515 as IE does not support gap
Why's this needed?
From what I understand, what is currently available in Stack.Item is an attempt to replace gap for IE, but since 516 is on the doorstep, I thought it would be a good idea to replace the current implementation, with a full-fledged
gap
.As I wrote above, the changes are incompatible with 515, so PR will be in draft until 516 is stable and the servers finally move to it
Plus, many interfaces would have to be considered, replacing the margin cancelations in Stack.Item with margin -1 or gap 0 (Although even if you don't, nothing critical will happen)