Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[516 ONLY] Add gap prop & replace Stack.Item margin with Stack gap #70

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AyIong
Copy link
Contributor

@AyIong AyIong commented Jan 24, 2025

About the PR

It's all said in the title. Adds props responsible for: column-gap, row-gap & gap.
This PR is fully uncompatible with Byond 515 as IE does not support gap

Why's this needed?

From what I understand, what is currently available in Stack.Item is an attempt to replace gap for IE, but since 516 is on the doorstep, I thought it would be a good idea to replace the current implementation, with a full-fledged gap.

As I wrote above, the changes are incompatible with 515, so PR will be in draft until 516 is stable and the servers finally move to it
Plus, many interfaces would have to be considered, replacing the margin cancelations in Stack.Item with margin -1 or gap 0 (Although even if you don't, nothing critical will happen)

@tgstation-ci
Copy link

tgstation-ci bot commented Jan 24, 2025

Thank you for contributing to tgui-core! The workflow 'Chromatic Security' requires repository secrets and will not run without approval. Maintainers can add the CI Cleared label to allow it to run. Note that any changes to chromaitc-security.yml and chromatic.yml will not be reflected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant