Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use update-prometheus-3.0 branch #8090

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use update-prometheus-3.0 branch #8090

wants to merge 2 commits into from

Conversation

SungJin1212
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

This PR applies a update-prometheus-3.0 branch of the promql-engine.

@SungJin1212 SungJin1212 marked this pull request as draft February 5, 2025 04:20
@SungJin1212 SungJin1212 force-pushed the Merge-promql-engine-updating-prometheus-v3.1.0 branch from a2e7798 to d481be4 Compare February 5, 2025 04:56
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Feb 5, 2025
@SungJin1212 SungJin1212 force-pushed the Merge-promql-engine-updating-prometheus-v3.1.0 branch from d481be4 to 9a49d37 Compare February 5, 2025 05:18
@SungJin1212 SungJin1212 force-pushed the Merge-promql-engine-updating-prometheus-v3.1.0 branch from 9a49d37 to 5e2c46f Compare February 5, 2025 05:30
yeya24
yeya24 reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work. Shall we just merge the 3.0 promql engine branch into its main first? Then update thanos here

@SungJin1212
Copy link
Contributor Author

SungJin1212 commented Feb 6, 2025 •
edited
Loading

@yeya24
�Should we correct the TestQuerier_Proxy test first?

Shall we just merge the 3.0 promql engine branch into its main first?

yeah, it would be nice to merge the promql engine first.

@SungJin1212
Fix TestQuerier_Proxy
97f150b 
Signed-off-by: SungJin1212 <[email protected]>
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Feb 6, 2025
yeya24
yeya24 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Tests result look good!
Once promql engine is merged to main this is good to go to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SungJin1212 @yeya24