Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/override favorite group #206

Merged
merged 5 commits into from
Mar 14, 2021
Merged

feat/override favorite group #206

merged 5 commits into from
Mar 14, 2021

Conversation

thdk
Copy link
Owner

@thdk thdk commented Mar 14, 2021

  • chore: use dev environment by default for webpack build
  • feat: allow to override existing favorite registration group

@thdk thdk closed this Mar 14, 2021
@thdk thdk reopened this Mar 14, 2021
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #206 (039317c) into master (a04d243) will increase coverage by 0.42%.
The diff coverage is 75.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   71.32%   71.75%   +0.42%     
==========================================
  Files         239      239              
  Lines        3815     3827      +12     
  Branches      653      656       +3     
==========================================
+ Hits         2721     2746      +25     
+ Misses       1084     1070      -14     
- Partials       10       11       +1     
Impacted Files Coverage Δ
src/containers/app/index.tsx 100.00% <ø> (ø)
src/routes/favorites/detail.tsx 36.84% <0.00%> (+2.69%) ⬆️
src/routes/registrations/detail.tsx 34.09% <ø> (ø)
src/routes/registrations/overview.tsx 46.51% <0.00%> (ø)
src/components/editable-text/index.tsx 43.75% <28.57%> (-4.25%) ⬇️
src/containers/ui/top-bar/top-bar-container.tsx 100.00% <100.00%> (ø)
src/stores/favorite-store/favorite-store.ts 98.18% <100.00%> (+31.51%) ⬆️
src/stores/user-store/user-store.ts 80.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb50397...039317c. Read the comment docs.

@thdk
Copy link
Owner Author

thdk commented Mar 14, 2021

This PR should already reduce the problem mentioned in #205

@thdk thdk merged commit 9d8405c into master Mar 14, 2021
@thdk thdk deleted the feat/override-favorite-group branch March 14, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant