Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update 84codes/crystal docker tag to v1.15.0 #8145

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2025

This PR contains the following updates:

Package Type Update Change
84codes/crystal stage minor 1.14.1-debian-bookworm -> 1.15.0-debian-bookworm

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from waghanza as a code owner January 10, 2025 12:41
@waghanza
Copy link
Collaborator

cc @@shootingfly

@shootingfly
Copy link
Contributor

okay, I will update it last week.

@shootingfly
Copy link
Contributor

@waghanza Because I defined a class named Index in Runcobo, it conflicts with the code in Crystal Standard Library. It is a bug for Crystal Lang.

class Index < BaseAction
  get "/"

  call do
    render_plain ""
  end
end

Code in src/crystal/event_loop/polling.cr

protected abstract def system_add(fd : Int32, index : Index) : Nil

I think it should be

protected abstract def system_add(fd : Int32, index : Arena::Index) : Nil

I will update server.cr and create an issue for Crysal Lang.

@waghanza
Copy link
Collaborator

Could you then ping an accurate contributor, and open an issue on their side ?

I'll, in the meantime, use the current crystal version for runcobo

@shootingfly
Copy link
Contributor

shootingfly commented Jan 15, 2025

I fix it in PR #8156

@renovate renovate bot force-pushed the renovate/84codes-crystal-1.x branch from 5a8d2d0 to 3d33c22 Compare January 16, 2025 06:29
@waghanza waghanza merged commit ad04811 into master Jan 17, 2025
13 checks passed
@waghanza waghanza deleted the renovate/84codes-crystal-1.x branch January 17, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants