Updating not-logged in UI #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2c50c7a): https://tcl-67-smart-shopping-list--pr82-feature-before-logge-ooljq4g6.web.app (expires Tue, 02 Apr 2024 22:34:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c |
aberger3647
reviewed
Mar 26, 2024
| <h1>Smart shopping list</h1> | ||
| {!!user ? ( | ||
| <div className="Layout"> | ||
| {!!user ? ( |
There was a problem hiding this comment.
I'm curious what the double !! is for?
There was a problem hiding this comment.
I think !! evaluates something as a boolean, so in this case !!user would equal to true or false, rather than evaluating it as a truthy or falsy. In this case maybe just user ? would have been enough? But it was the way it was originally, so I just kept it. @aberger3647
flbarfield
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
Updates Layout.jsx to update UI based on whether user is logged in or not.
Related Issue
#63
Acceptance Criteria
Logged in displays app as normal.
Logged out displays a text display to "Please sign in to view lists."
Type of Changes
Feature update.
Updates
Before
After
Testing Steps / QA Criteria