Handle invalid report requests properly (#645)

Sorry i forgot where I was in f07b003.
the-draupnir-project · Dec 18, 2024 · e24bb80 · e24bb80
1 parent bd86e73
commit e24bb80
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/webapis/WebAPIs.ts b/src/webapis/WebAPIs.ts
@@ -92,14 +92,22 @@ export class WebAPIs {
           const roomID = request.params.room_id;
           const eventID = request.params.event_id;
           if (!isStringRoomID(roomID)) {
-            throw new TypeError(
+            log.error(
               `Invalid roomID provided when processing a report, check your webproxy: ${roomID}`
             );
+            response
+              .status(400)
+              .send({ errcode: "M_INVALID_PARAM", error: "Invalid room ID" });
+            return;
           }
           if (!isStringEventID(eventID)) {
-            throw new TypeError(
+            log.error(
               `Invalid eventID provided when processing a report, check your webproxy: ${eventID}`
             );
+            response
+              .status(400)
+              .send({ errcode: "M_INVALID_PARAM", error: "Invalid event ID" });
+            return;
           }
           void Task(
             this.handleReport({