Fix report poller #662
Merged
Fix report poller #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honestly, I'm going to revert this because I think I have found a better way of testing the report poller.
We need to change the ReportManager so that we can interface it out for testing. The reason being that the report poller is inactive in the harness and so we can't use that with a protection handle to test. Instead I want to instantiate a report poller with a mocked report manager.
We need this so that we can test the report poller without needing to do gymnastics to selectively forward reports.
Needed so we can test the report poller without doing gymnastics with setting up fake protections.
This reverts commit 59b335f. We don't need this anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258
Fixes #408
Fixes #409