Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter parameter for bump_packages #11101

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/bump_packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ name: Update packages

on:
workflow_dispatch:
inputs:
filter:
type: string
description: A filter to apply on package names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package names have different structure between Debian and EL. Should this filter rather be on the "source" name?
So, passing foreman_maintain here will update ruby-foreman-maintain on Debian and rubygem-foreman_maintain on RPM?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. In the update scripts we know the gem name so we can match against that

required: false
default: ""
schedule:
- cron: '4 4 * * 0,3'

Expand All @@ -23,7 +29,7 @@ jobs:
ref: rpm/develop
- name: Set the list
id: set_list
run: ./list_updatable_packages
run: ./list_updatable_packages "${{ inputs.filter }}"

bump_rpm:
name: 'Bump ${{ matrix.package_name }} RPM ${{ matrix.new_version }}'
Expand Down Expand Up @@ -84,7 +90,7 @@ jobs:
ref: deb/develop
- name: Set the list
id: set_list
run: ./scripts/list_updatable_packages
run: ./scripts/list_updatable_packages "${{ inputs.filter }}"

bump_plugin_deb:
name: 'Bump ${{ matrix.package_name }} deb ${{ matrix.new_version }}'
Expand Down