Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nodejs-jquery to 3.7.1 #11658

Open
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from
Open

Update nodejs-jquery to 3.7.1 #11658

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 24, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot requested a review from a team as a code owner January 24, 2025 18:28
@github-actions github-actions bot force-pushed the bump_rpm/nodejs-jquery branch 2 times, most recently from ba65e84 to 7f0bdaf Compare January 27, 2025 18:15
evgeni
evgeni requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break

foreman-packaging/packages/katello/nodejs-bootstrap-select/nodejs-bootstrap-select.spec

Lines 17 to 18 in 7a6d5c4

Requires: %{?scl_prefix}npm(jquery) >= 1.9.1
Requires: %{?scl_prefix}npm(jquery) < 3

But I am not sure we still need that?

Edit: Katello still depends on that.

@github-actions github-actions bot force-pushed the bump_rpm/nodejs-jquery branch from 7f0bdaf to 110f480 Compare January 29, 2025 04:11
@github-actions github-actions bot force-pushed the bump_rpm/nodejs-jquery branch 5 times, most recently from 6d9408b to 5f7bf12 Compare February 5, 2025 04:11
@github-actions github-actions bot force-pushed the bump_rpm/nodejs-jquery branch from 5f7bf12 to b0cec55 Compare February 9, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs re-review RPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evgeni