Add ability to update spec files for nodejs and gems #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the mock commit wasn't intended to be here, correct? |
|
Yes and no. It is not required but while I iterate on any design updates, it's helpful for me to have both the mock and update-spec commands handy locally at the same time :) |
|
Github allows draft PRs for this purpose :) |
|
Truth .. they need to allow setting that after you open it :/ |
ehelms
force-pushed
the
update-spec
branch
2 times, most recently
from
f624e8e to
eb1d546
Compare
|
This now needs a rebase. |
ehelms
changed the title
|
The only thing that this might not do properly is I think that it does doubles up on the changelog instead of printing it once. Everything else, at least for the gems, seems to work properly! |
ehelms
force-pushed
the
update-spec
branch
2 times, most recently
from
914a882 to
dae9765
Compare
ehelms
force-pushed
the
update-spec
branch
4 times, most recently
from
5c5203d to
ba8a55b
Compare
|
My doubling changelog comment is no longer an issue. |
zjhuntin
approved these changes
Apr 16, 2020
ehelms
force-pushed
the
update-spec
branch
2 times, most recently
from
9d2dd13 to
ef2a486
Compare
This was referenced Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes another PR thats required. This adds the ability to update just the spec file of a package (for NPM and Gems) and thus do it en masse. The playbook is a bit messy and I am willing to break it up depending on how folks feel about the design.