👷Explicitly run the effection linked tests against v2 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The process infrastructure was moved out of effection core in v3, but this resulted in the build getting broken when the default branch switch from v2-v3. We do not need this at all now that v2 is not longer maintained.
cowboyd
force-pushed
the
cl/only-run-effection-linked-v2
branch
from
e900c23 to
ac7ac3d
Compare
jbolda
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The process infrastructure was moved out of effection core in v3, but this resulted in the build getting broken when the default branch switch from v2-v3. Among other things, this is causing #47 to fail its tests.
Approach
This explicitly uses v2 when checking against a linked effection.
We may not need to do this at all in the future, or perhaps check it with v4 contrib.