Fix realm mismatches in Vector:toScreen() and Vehicle:getDriver() (#1581

)

* Vector:toScreen() is client-only

* :getDriver() and :getPassenger() are shared

* Fix trailing whitespace

lua/starfall/libs_sh/vectors.lua

@@ -470,12 +470,6 @@ function vec_methods:set(v)
 	self[3] = v[3]
 end
 
---- Translates the vectors position into 2D user screen coordinates.
--- @return table A table {x=screenx,y=screeny,visible=visible}
-function vec_methods:toScreen()
-	return unwrap(self):ToScreen()
-end
-
 --- Converts vector to color
 -- @return Color New color object
 function vec_methods:getColor()
@@ -501,6 +495,13 @@ if SERVER then
 	function vec_methods:isInWorld()
 		return util.IsInWorld(unwrap(self))
 	end
+else
+	--- Translates the vectors position into 2D user screen coordinates.
+	-- @client
+	-- @return table A table {x=screenx,y=screeny,visible=visible}
+	function vec_methods:toScreen()
+		return unwrap(self):ToScreen()
+	end
 end
 
 end

lua/starfall/libs_sh/vehicles.lua

@@ -41,14 +41,21 @@ function vehicle_meta:__tostring()
 	else return tostring(ent) end
 end
 
-if SERVER then
-	--- Returns the driver of the vehicle
-	-- @server
-	-- @return Player Driver of vehicle
-	function vehicle_methods:getDriver()
-		return pwrap(getveh(self):GetDriver())
-	end
+--- Returns the driver of the vehicle
+-- @return Player Driver of vehicle
+function vehicle_methods:getDriver()
+	return pwrap(getveh(self):GetDriver())
+end
+
+--- Returns a passenger of a vehicle
+-- @param number n The index of the passenger to get
+-- @return Player The passenger or NULL if empty
+function vehicle_methods:getPassenger(n)
+	checkluatype(n, TYPE_NUMBER)
+	return pwrap(getveh(self):GetPassenger(n))
+end
 
+if SERVER then
 	--- Ejects the driver of the vehicle
 	-- @server
 	function vehicle_methods:ejectDriver()
@@ -58,15 +65,6 @@ if SERVER then
 		end
 	end
 
-	--- Returns a passenger of a vehicle
-	-- @server
-	-- @param number n The index of the passenger to get
-	-- @return Player The passenger or NULL if empty
-	function vehicle_methods:getPassenger(n)
-		checkluatype(n, TYPE_NUMBER)
-		return pwrap(getveh(self):GetPassenger(n))
-	end
-
 	--- Kills the driver of the vehicle
 	-- @server
 	function vehicle_methods:killDriver()
@@ -102,7 +100,7 @@ if SERVER then
 		checkpermission(instance, ent, "vehicle.lock")
 		local n = "SF_CanExitVehicle"..ent:EntIndex()
 		hook.Add("CanExitVehicle", n, function(v) if v==ent then return false end end)
-		ent:CallOnRemove(n, function() hook.Remove("CanExitVehicle", n) end) 
+		ent:CallOnRemove(n, function() hook.Remove("CanExitVehicle", n) end)
 		ent:Fire("Lock")
 	end