Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require either a HUD connection or the permission for bass.play2D #1795

Conversation

Periapsises
Copy link
Contributor

Fixed 2D bass sounds requiring both a permission and a HUD connection to work.
It now requires one or the other.

Copy link
Collaborator

@adamnejm adamnejm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still throw an error if the player isn't connected to a HUD, maybe something like:

if is2D and not (SF.IsHUDActive(instance.entity) or haspermission(instance, nil, "bass.play2D")) then
  SF.Throw("Player isn't connected to HUD or doesn't have the blablabla perm!", 2)
end

@thegrb93
Copy link
Owner

Maybe an option can be added to the 'client' permission provider for 'allow if hud connected'. That way the user can switch the 2d permission to either 'allow/allow if hud connected'

@Periapsises Periapsises closed this Aug 3, 2024
@Periapsises Periapsises deleted the bugfix/bass2d_requires_hud_and_permission branch August 3, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants