Add Hologram:setCullMode() #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think cullmode can be controlled via the material right? Are you able to use a material instead? |
|
Would this be better than using render.CullMode() for the purpose? Please explain. |
|
This adds passive render overhead to hologram. I've been thinking about making a function that builds the hologram render function so maybe that'll optimize it anyway. |
|
My only other complaint is that cullmode has 3 modes and your bool only allows support for 2 modes. |
|
3 modes? I was under the impression that render.CullMode() only had two modes. Are you referring to the nocull material flag? |
|
Huh, I swear there used to be a 'none' cullmode which would make the faces draw on both sides. |
|
I guess I was just thinking of the nocull material flag |
thegrb93
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function that allows for the cull direction of holograms to be changed without forcing the user to create a render hook