Refactor ppdata #1827
Merged
Refactor ppdata #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make starfall error hook use 'world' for server errors * Use world instead of false for server errors
* Add Entity:getRenderBounds() * Edit Entity:getRenderBounds()
* add E2 to :hasInstance() * return false if neither sf or e2
* For prop.createSent(): check if frozen is a boolean I forgot to specify `frozen` in one of my SF projects and my `data` ended up in its place, yet I received no error and it wasn't until I spent 1 second of my life to double-check docs when I fixed my problem. I highly doubt anyone is going to get any problems with me adding one extra check that 99% of good starfalls won't crash from. * Update lua/starfall/libs_sv/prop.lua Co-authored-by: thegrb93 <[email protected]> * Update prop.lua * Update prop.lua
* Copy frozen prop param fix to other spawn functions * Missed one
|
Seems to be working now. Just need to test all the require and include functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.