-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cost Tests #637
Cost Tests #637
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
+ Coverage 77.45% 78.27% +0.81%
==========================================
Files 36 36
Lines 3589 3765 +176
Branches 633 665 +32
==========================================
+ Hits 2780 2947 +167
- Misses 542 543 +1
- Partials 267 275 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @selmanozleyen . see minor comments
Ok, I also added tests for leaf_distance which should cover everything except one case in |
Hi!
This PR is meant to solve #632,
Currently I am testing the initialization of the objects, the special cases, and functionality with only using sample input and expected outputs.
Remaining tasks besides the future feedback:
ping: @giovp , @MUCDK