Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't open multiselect dropdown on clicking selected items #1431

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

MarkNerdi
Copy link
Contributor

@MarkNerdi MarkNerdi commented Sep 12, 2024

Closes #

📑 Description

Currently the Multiselect always opens, no matter where you click inside of it. So if the user has an item selected (and added as a Badge inside the input), and they click on it, the dropdown opens, but without focus.
This results in a not-closable dropdown on outside clicks

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

Copy link

vercel bot commented Sep 12, 2024

@MarkNerdi is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 12, 2024

Walkthrough

The changes made in the MultiSelect.svelte file focus on refining event handling for user interactions. The on:click event for the main <div> and the <svg> element has been updated to utilize the |self modifier, ensuring that the toggle action for the show state is only activated when the respective elements are clicked directly. This adjustment aims to enhance the control flow of user interactions within the component.

Changes

File Change Summary
src/lib/forms/MultiSelect.svelte Modified on:click event handlers for <div> and <svg> elements to use the `

Poem

In the garden where rabbits play,
A click now brings a brighter day.
With careful hops and joyful cheer,
We toggle states without a fear.
A dance of clicks, so neat and spry,
MultiSelect, oh my, oh my! 🐇✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 235523d and e384fb2.

Files selected for processing (1)
  • src/lib/forms/MultiSelect.svelte (2 hunks)
Additional comments not posted (2)
src/lib/forms/MultiSelect.svelte (2)

122-122: LGTM!

The addition of the |self modifier to the on:click event handler is a good change. It ensures that the show state is only toggled when the <div> itself is clicked, not its child elements. This improves the control flow and prevents unintended behavior.


142-142: Looks good!

The addition of the |self modifier to the on:click event handler for the <svg> element is a positive change. It ensures that the show state is only toggled when the SVG itself is clicked directly. This improves the accessibility and usability of the component by refining how user interactions are handled.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MarkNerdi MarkNerdi changed the title fix: don't open multiselect dropdown on removing selected items fix: don't open multiselect dropdown on clicking selected items Sep 12, 2024
Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 2:23pm

@shinokada shinokada merged commit 8c4adbb into themesberg:main Sep 21, 2024
1 check passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants