fix: base64 encoded image download filename #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using base64 encoded image strings, and when trying to download the picture, the parsing currently in place does not work.
ex: self hosted - http://example.com/file1.png
filename = file1.png
ex: base64 encoded - data:image/jpg;base64,/9j/....
filename = some characters at the end of the last forward slash.
I propose adding an additional argument to the IAlbum interface called fileName, to allow users to override the default attempt of naming downloaded files.