Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Promise.any() #174

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

@rollingversions
Copy link

rollingversions bot commented Sep 6, 2022

var error = new Error('All promises were rejected');

error.name = 'AggregateError';
error.errors = errors;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wandering is it correct way of polyfilling this AggregateError

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "good enough" as a polyfill.

var error = new Error('All promises were rejected');

error.name = 'AggregateError';
error.errors = errors;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "good enough" as a polyfill.

@ForbesLindesay ForbesLindesay merged commit 9d5851d into then:master Oct 25, 2022
@ForbesLindesay
Copy link
Member

I've just released this as v8.3.0

@retyui
Copy link
Contributor Author

retyui commented Oct 25, 2022

Thanks for quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants