-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Promise.any()
#174
Conversation
Change Log for promise (8.2.0 → 8.3.0)New Features
|
var error = new Error('All promises were rejected'); | ||
|
||
error.name = 'AggregateError'; | ||
error.errors = errors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wandering is it correct way of polyfilling this AggregateError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "good enough" as a polyfill.
var error = new Error('All promises were rejected'); | ||
|
||
error.name = 'AggregateError'; | ||
error.errors = errors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "good enough" as a polyfill.
I've just released this as v8.3.0 |
Thanks for quick review! |
Issue: #86
Promise.any()
: