Merge pull request #274 from tovrstra/fix-pylint-2.9.3

Fix pylint 2.9.3
theochem · Jul 5, 2021 · a7d7d59 · a7d7d59
2 parents 1de4661 + e80e463
commit a7d7d59
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -93,7 +93,7 @@ jobs:
             !~/miniconda3/envs/*/locks
             !~/miniconda3/envs/*/pkgs
             !~/miniconda3/envs/*/var
-          key: ${{ runner.os }}-conda-3
+          key: ${{ runner.os }}-conda-4
       - name: Install Roberto
         run: |
           python -m pip install roberto>=2.0.0

diff --git a/iodata/test/test_cube.py b/iodata/test/test_cube.py
@@ -104,7 +104,8 @@ def test_load_dump_h2o_5points(tmpdir):
     fn_cube2 = tmpdir.join('iodata_h2o_5points.cube')
     dump_one(mol1, fn_cube2)
     # read the contents as string (skip the first 2 lines) & compare
-    content1 = open(fn_cube1, "r").read().split("\n", 2)[-1]
+    with open(fn_cube1, "r") as f:
+        content1 = f.read().split("\n", 2)[-1]
     content2 = fn_cube2.read().split("\n", 2)[-1]
     assert content1 == content2
 
@@ -117,7 +118,8 @@ def test_load_dump_ch4_6points(tmpdir):
     fn_cube2 = tmpdir.join('iodata_ch4_6points.cube')
     dump_one(mol1, fn_cube2)
     # read the contents as string (skip the first 2 lines) & compare
-    content1 = open(fn_cube1, "r").read().split("\n", 2)[-1]
+    with open(fn_cube1, "r") as f:
+        content1 = f.read().split("\n", 2)[-1]
     content2 = fn_cube2.read().split("\n", 2)[-1]
     assert content1 == content2
 
@@ -130,6 +132,7 @@ def test_load_dump_nh3_7points(tmpdir):
     fn_cube2 = tmpdir.join('iodata_nh3_7points.cube')
     dump_one(mol1, fn_cube2)
     # read the contents as string (skip the first 2 lines) & compare
-    content1 = open(fn_cube1, "r").read().split("\n", 2)[-1]
+    with open(fn_cube1, "r") as f:
+        content1 = f.read().split("\n", 2)[-1]
     content2 = fn_cube2.read().split("\n", 2)[-1]
     assert content1 == content2