Transformers #3
Draft
Transformers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch does a bunch of small fixes and one big change
The One Big Change is that the conversion process works in two steps . The first one transforms the incoming python AST into an uglier version of itself which reflects the structure of a ZScript. The second one handles the formatting of the reconfigured AST into ZScript. This removes a lot of the complexity in the original. The nice thing about this new setup is that it allows for more intelligent rewriting -- in particular, it makes it possible to convert Python returns in to the Zbrush "out return" fornat without extra work from the programmer