Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run some tests against a real dav server #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Run some tests against a real dav server #56

wants to merge 1 commit into from

Conversation

kesselb
Copy link

@kesselb kesselb commented Jul 10, 2019

No description provided.

@frankdejonge
Copy link
Member

I'm heading to bed now, but looking forward to land this 👍 great contribution.

@kesselb kesselb changed the title Run some tests against a real dav server WIP: Run some tests against a real dav server Jul 10, 2019
@kesselb
Copy link
Author

kesselb commented Jul 10, 2019

Added the test scenarios from https://github.com/thephpleague/flysystem/blob/master/tests/ftp/FtpIntegrationTestCase.php. Could not extend from FtpIntegrationTestCase because the class has no namespace. Tests are failing due to https://github.com/thephpleague/flysystem-webdav/issues/53

@kesselb
Copy link
Author

kesselb commented Jul 10, 2019

Tests will run after #57

@kesselb kesselb mentioned this pull request Sep 6, 2019
Merged
@kesselb kesselb changed the title WIP: Run some tests against a real dav server Run some tests against a real dav server Dec 15, 2019
@kesselb
Copy link
Author

kesselb commented Dec 15, 2019

Ready for review @frankdejonge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kesselb @frankdejonge