Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useful error descriptions #1175

Draft
wants to merge 10 commits into
base: 9.0.0-WIP
Choose a base branch
from
Draft

Useful error descriptions #1175

wants to merge 10 commits into from

Conversation

Sephster
Copy link
Member

This PR removes the hints from the OAuthException class and instead, provides more useful error messages in the default exception error message.

@Sephster Sephster marked this pull request as draft December 12, 2020 00:14
@Sephster
Copy link
Member Author

Will address issues raised in issue #1093

@Sephster
Copy link
Member Author

  • Convert exception class to final
  • Remove previous reference in changelog of hint fix for invalid credentials on the password grant

@lucianobosco
Copy link

Hi, any updates on this? I'm facing a 401 unauthenticated response in Laravel when credentials are wrong. Does this PR resolve/clarify in some way the returning errors?

@marc-mabe marc-mabe mentioned this pull request May 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sephster @lucianobosco